From 0bf3ee1a6fdbfa4c332cd53b8563d89fff6c8bc8 Mon Sep 17 00:00:00 2001 From: Raphael Michel Date: Sun, 10 Nov 2019 13:07:06 +0100 Subject: [PATCH] Refactor into method in ClassicInvoiceRenderer --- src/pretix/base/invoice.py | 31 ++++++++++++++++++------------- 1 file changed, 18 insertions(+), 13 deletions(-) diff --git a/src/pretix/base/invoice.py b/src/pretix/base/invoice.py index 12c59a2e17..090a0dd110 100644 --- a/src/pretix/base/invoice.py +++ b/src/pretix/base/invoice.py @@ -457,19 +457,8 @@ class ClassicInvoiceRenderer(BaseReportlabInvoiceRenderer): id='normal') ] - def _get_story(self, doc): - has_taxes = any(il.tax_value for il in self.invoice.lines.all()) - - story = [ - NextPageTemplate('FirstPage'), - Paragraph(pgettext('invoice', 'Invoice') - if not self.invoice.is_cancellation - else pgettext('invoice', 'Cancellation'), - self.stylesheet['Heading1']), - Spacer(1, 5 * mm), - NextPageTemplate('OtherPages'), - ] - + def _get_intro(self): + story = [] if self.invoice.internal_reference: story.append(Paragraph( pgettext('invoice', 'Customer reference: {reference}').format(reference=self.invoice.internal_reference), @@ -494,6 +483,22 @@ class ClassicInvoiceRenderer(BaseReportlabInvoiceRenderer): story.append(Paragraph(self.invoice.introductory_text, self.stylesheet['Normal'])) story.append(Spacer(1, 10 * mm)) + return story + + def _get_story(self, doc): + has_taxes = any(il.tax_value for il in self.invoice.lines.all()) + + story = [ + NextPageTemplate('FirstPage'), + Paragraph(pgettext('invoice', 'Invoice') + if not self.invoice.is_cancellation + else pgettext('invoice', 'Cancellation'), + self.stylesheet['Heading1']), + Spacer(1, 5 * mm), + NextPageTemplate('OtherPages'), + ] + story += self._get_intro() + taxvalue_map = defaultdict(Decimal) grossvalue_map = defaultdict(Decimal)