Transmit invoices generated due to paymentprovider changes (Z#23242806)

This commit is contained in:
Kara Engelhardt
2026-08-24 13:45:54 +02:00
committed by pajowu
parent 64a5361dba
commit 0593172146
2 changed files with 73 additions and 9 deletions
+12 -7
View File
@@ -3469,7 +3469,7 @@ def change_payment_provider(order: Order, payment_provider, amount=None, new_pay
}
)
new_invoice_created = False
new_invoice = None
if recreate_invoices:
# Lock to prevent duplicate invoice creation
order = Order.objects.select_for_update(of=OF_SELF).get(pk=order.pk)
@@ -3480,13 +3480,16 @@ def change_payment_provider(order: Order, payment_provider, amount=None, new_pay
if has_active_invoice and order.total != oldtotal:
try:
generate_cancellation(i)
generate_invoice(order)
new_invoice = generate_invoice(order)
except Exception as e:
logger.exception("Could not generate invoice.")
order.log_action("pretix.event.order.invoice.failed", data={
"exception": str(e)
})
new_invoice_created = True
else:
order.log_action('pretix.event.order.invoice.generated', data={
'invoice': new_invoice.pk
})
elif (not has_active_invoice or order.invoice_dirty) and invoice_qualified(order):
if order.event.settings.get('invoice_generate') == 'True' or (
@@ -3496,10 +3499,9 @@ def change_payment_provider(order: Order, payment_provider, amount=None, new_pay
try:
if has_active_invoice:
generate_cancellation(i)
i = generate_invoice(order)
new_invoice_created = True
new_invoice = generate_invoice(order)
order.log_action('pretix.event.order.invoice.generated', data={
'invoice': i.pk
'invoice': new_invoice.pk
})
except Exception as e:
logger.exception("Could not generate invoice.")
@@ -3507,8 +3509,11 @@ def change_payment_provider(order: Order, payment_provider, amount=None, new_pay
"exception": str(e)
})
if new_invoice and invoice_transmission_separately(new_invoice):
transmit_invoice.apply_async(args=(order.event_id, new_invoice.pk, False))
order.create_transactions()
return old_fee, new_fee, fee, new_payment, new_invoice_created
return old_fee, new_fee, fee, new_payment, bool(new_invoice)
@receiver(order_paid, dispatch_uid="pretixbase_order_paid_giftcards")