[A11y] Test for autofocus tabindex UX

src/pretix/base/customersso/oidc.py

@@ -24,7 +24,7 @@ import hashlib
 import logging
 import time
 from datetime import datetime
-from urllib.parse import parse_qsl, urlencode, urljoin
+from urllib.parse import urlencode, urljoin
 
 import jwt
 import requests
@@ -139,11 +139,6 @@ def oidc_validate_and_complete_config(config):
                 )
             )
 
-    if "query_parameters" in config and config["query_parameters"]:
-        config["query_parameters"] = urlencode(
-            parse_qsl(config["query_parameters"])
-        )
-
     config['provider_config'] = provider_config
     return config
 
@@ -159,10 +154,6 @@ def oidc_authorize_url(provider, state, redirect_uri):
         'state': state,
         'redirect_uri': redirect_uri,
     }
-
-    if "query_parameters" in provider.configuration and provider.configuration["query_parameters"]:
-        params.update(parse_qsl(provider.configuration["query_parameters"]))
-
     return endpoint + '?' + urlencode(params)
 
 

src/pretix/control/forms/organizer.py

@@ -1043,15 +1043,6 @@ class SSOProviderForm(I18nModelForm):
         label=pgettext_lazy('sso_oidc', 'Phone field'),
         required=False,
     )
-    config_oidc_query_parameters = forms.CharField(
-        label=pgettext_lazy('sso_oidc', 'Query parameters'),
-        help_text=pgettext_lazy('sso_oidc', 'Optional query parameters, that will be added to calls to '
-                                            'the authorization endpoint. Enter as: {example}'.format(
-                                                example='<code>param1=value1&amp;param2=value2</code>'
-                                            ),
-                                ),
-        required=False,
-    )
 
     class Meta:
         model = CustomerSSOProvider

src/pretix/control/templates/pretixcontrol/dashboard.html

@@ -7,7 +7,7 @@
     <div class="dropdown-container">
         <input type="text" class="form-control" id="dashboard_query"
                 placeholder="{% trans "Go to event" %}"
-                data-typeahead-query autofocus>
+                data-typeahead-query tabindex="1" autofocus>
         <ul data-event-typeahead data-source="{% url "control:nav.typeahead" %}" data-typeahead-field="#dashboard_query"
                 class="event-dropdown dropdown-menu">
         </ul>