From ff5c649cfc19834db9fcf5679f9d445f99cb70c1 Mon Sep 17 00:00:00 2001 From: Richard Schreiber Date: Thu, 5 May 2022 17:40:17 +0200 Subject: [PATCH] Fix: Ignore string identifiers when converting old to new question placeholders --- src/pretix/plugins/badges/signals.py | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/src/pretix/plugins/badges/signals.py b/src/pretix/plugins/badges/signals.py index 228cab50b..fcc1cdeb8 100644 --- a/src/pretix/plugins/badges/signals.py +++ b/src/pretix/plugins/badges/signals.py @@ -99,9 +99,15 @@ def event_copy_data_receiver(sender, other, question_map, item_map, **kwargs): for o in layout: if o['type'] == 'textarea': if o['content'].startswith('question_'): - newq = question_map.get(int(o['content'][9:])) - if newq: - o['content'] = 'question_{}'.format(newq.pk) + try: + newq = question_map.get(int(o['content'][9:])) + except ValueError: + # int cannot convert new placeholders question_{identifier} + # can be safely ignored as only old format questions_{pk} should be converted + pass + else: + if newq: + o['content'] = 'question_{}'.format(newq.pk) bl.layout = json.dumps(layout) bl.save()