CGM_Public/pretix_cgo
1
0
Fork 0
forked from CGM_Public/pretix_original
Code Pull Requests Actions Activity

Fix voucher tag overview with MySQL (closes #253) (#254)

Browse Source 
This is a fix for this MySQL issue: https://code.djangoproject.com/ticket/24662
It is (imo) the best solution over custom SQL queries or explicit int
casting later on.
This commit is contained in:
Tobias Kunze
2016-09-27 11:42:58 +02:00
committed by Raphael Michel
parent 6d894bf98c
commit f955c35f2d
1 changed files with 9 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/pretix/control/views/vouchers.py
View File

@@ -5,7 +5,7 @@ from django.conf import settings
from django.contrib import messages from django.contrib import messages
from django.core.urlresolvers import resolve, reverse from django.core.urlresolvers import resolve, reverse
from django.db import transaction from django.db import transaction
from django.db.models import Count, Q, Sum from django.db.models import Case, Count, IntegerField, Q, Sum, When
from django.http import ( from django.http import (
Http404, HttpResponse, HttpResponseBadRequest, HttpResponseRedirect, Http404, HttpResponse, HttpResponseBadRequest, HttpResponseRedirect,
JsonResponse, JsonResponse,
@@ -97,7 +97,14 @@ class VoucherTags(EventPermissionRequiredMixin, TemplateView):
tags = self.request.event.vouchers.order_by('tag').filter(tag__isnull=False).values('tag').annotate( tags = self.request.event.vouchers.order_by('tag').filter(tag__isnull=False).values('tag').annotate(
total=Count('id'), total=Count('id'),
redeemed=Sum('redeemed') # This is a fix for this MySQL issue: https://code.djangoproject.com/ticket/24662
redeemed=Sum(
Case(
When(redeemed=True, then=1),
When(redeemed=False, then=0),
output_field=IntegerField()
)
)
) )
for t in tags: for t in tags:
t['percentage'] = int((t['redeemed'] / t['total']) * 100) t['percentage'] = int((t['redeemed'] / t['total']) * 100)