CGM_Public/pretix_cgo
1
0
Fork 0
forked from CGM_Public/pretix_original
Code Pull Requests Actions Activity

PayPal: Add missing payment.fail() statements

Browse Source
This commit is contained in:
Raphael Michel
2023-08-29 15:10:05 +02:00
parent 322a730eb2
commit efb1141d59
1 changed files with 18 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
src/pretix/plugins/paypal2/payment.py
View File

@@ -607,6 +607,12 @@ class PaypalMethod(BasePaymentProvider):
response = self.client.execute(req) response = self.client.execute(req)
except IOError as e: except IOError as e:
logger.exception('PayPal OrdersGetRequest: {}'.format(str(e))) logger.exception('PayPal OrdersGetRequest: {}'.format(str(e)))
payment.fail(info={
"error": {
"name": "IOError",
"message": str(e),
}
})
raise PaymentException(_('We had trouble communicating with PayPal')) raise PaymentException(_('We had trouble communicating with PayPal'))
else: else:
pp_captured_order = response.result pp_captured_order = response.result
@@ -618,6 +624,12 @@ class PaypalMethod(BasePaymentProvider):
if Decimal(pp_captured_order.purchase_units[0].amount.value) != payment.amount or \ if Decimal(pp_captured_order.purchase_units[0].amount.value) != payment.amount or \
pp_captured_order.purchase_units[0].amount.currency_code != self.event.currency: pp_captured_order.purchase_units[0].amount.currency_code != self.event.currency:
logger.error('Value mismatch: Payment %s vs paypal trans %s' % (payment.id, str(pp_captured_order.dict()))) logger.error('Value mismatch: Payment %s vs paypal trans %s' % (payment.id, str(pp_captured_order.dict())))
payment.fail(info={
"error": {
"name": "ValidationError",
"message": "Value mismatch",
}
})
raise PaymentException(_('We were unable to process your payment. See below for details on how to ' raise PaymentException(_('We were unable to process your payment. See below for details on how to '
'proceed.')) 'proceed.'))
@@ -660,6 +672,12 @@ class PaypalMethod(BasePaymentProvider):
self.client.execute(patchreq) self.client.execute(patchreq)
except IOError as e: except IOError as e:
messages.error(request, _('We had trouble communicating with PayPal')) messages.error(request, _('We had trouble communicating with PayPal'))
payment.fail(info={
"error": {
"name": "IOError",
"message": str(e),
}
})
logger.exception('PayPal OrdersPatchRequest: {}'.format(str(e))) logger.exception('PayPal OrdersPatchRequest: {}'.format(str(e)))
return return