From edf97a13cd0b47ea531f89a376ef16ece817adbe Mon Sep 17 00:00:00 2001
From: luelista <weller@rami.io>
Date: Tue, 9 Jun 2026 12:48:03 +0200
Subject: [PATCH] Don't show warning if inactive products are used in
 checkin-rules (Z#23236197) (#6242)

---
 src/pretix/control/views/checkin.py                    |  3 ++-
 .../static/pretixcontrol/js/ui/checkinrules/App.vue    |  6 +++---
 .../pretixcontrol/js/ui/checkinrules/django-interop.ts | 10 ++++++----
 3 files changed, 11 insertions(+), 8 deletions(-)

diff --git a/src/pretix/control/views/checkin.py b/src/pretix/control/views/checkin.py
index 3c640ce12..51775210c 100644
--- a/src/pretix/control/views/checkin.py
+++ b/src/pretix/control/views/checkin.py
@@ -401,13 +401,14 @@ class CheckinListUpdate(EventPermissionRequiredMixin, UpdateView):
                 {
                     'id': i.pk,
                     'name': str(i),
+                    'active': i.active,
                     'variations': [
                         {
                             'id': v.pk,
                             'name': str(v.value)
                         } for v in i.variations.all()
                     ]
-                } for i in self.request.event.items.filter(active=True).prefetch_related('variations')
+                } for i in self.request.event.items.prefetch_related('variations')
             ],
             **super().get_context_data(),
         }
diff --git a/src/pretix/static/pretixcontrol/js/ui/checkinrules/App.vue b/src/pretix/static/pretixcontrol/js/ui/checkinrules/App.vue
index 7c6f5c5cf..d23acfcf5 100644
--- a/src/pretix/static/pretixcontrol/js/ui/checkinrules/App.vue
+++ b/src/pretix/static/pretixcontrol/js/ui/checkinrules/App.vue
@@ -1,6 +1,6 @@
 <script setup lang="ts">
 import { computed } from 'vue'
-import { rules as rawRules, items, allProducts, limitProducts } from './django-interop'
+import { rules as rawRules, allItems, activeItems, allProducts, limitProducts } from './django-interop'
 import { convertToDNF } from './jsonlogic-boolalg'
 
 import RulesEditor from './checkin-rules-editor.vue'
@@ -53,7 +53,7 @@ const missingItems = computed(() => {
 	}
 
 	let missing = []
-	for (const item of items.value) {
+	for (const item of activeItems.value) {
 		if (productsSeen[item.id]) continue
 		if (!allProducts.value && !limitProducts.value.includes(item.id)) continue
 		if (item.variations.length > 0) {
@@ -87,7 +87,7 @@ const missingItems = computed(() => {
 
 		//- Tab panes
 		.tab-content
-			#rules-edit.tab-pane.active(v-if="items", role="tabpanel")
+			#rules-edit.tab-pane.active(v-if="allItems", role="tabpanel")
 				RulesEditor
 			#rules-viz.tab-pane(role="tabpanel")
 				RulesVisualization
diff --git a/src/pretix/static/pretixcontrol/js/ui/checkinrules/django-interop.ts b/src/pretix/static/pretixcontrol/js/ui/checkinrules/django-interop.ts
index df7978a2c..982fc58f5 100644
--- a/src/pretix/static/pretixcontrol/js/ui/checkinrules/django-interop.ts
+++ b/src/pretix/static/pretixcontrol/js/ui/checkinrules/django-interop.ts
@@ -26,11 +26,13 @@ watch(rules, (newVal) => {
 	rulesInput.value = JSON.stringify(newVal)
 }, { deep: true })
 
-export const items = ref<any[]>([])
+export const activeItems = ref<any[]>([])
+export const allItems = ref<any[]>([])
 
 const itemsEl = document.querySelector('#items')
 if (itemsEl?.textContent) {
-	items.value = JSON.parse(itemsEl.textContent || '[]')
+	allItems.value = JSON.parse(itemsEl.textContent || '[]')
+	activeItems.value = allItems.value.filter(item => item.active)
 
 	function checkForInvalidIds (validProducts: Record<string, string>, validVariations: Record<string, string>, rule: any) {
 		if (rule['and']) {
@@ -57,8 +59,8 @@ if (itemsEl?.textContent) {
 	}
 
 	checkForInvalidIds(
-		Object.fromEntries(items.value.map(p => [p.id, p.name])),
-		Object.fromEntries(items.value.flatMap(p => p.variations?.map(v => [v.id, p.name + ' – ' + v.name]) ?? [])),
+		Object.fromEntries(allItems.value.map(p => [p.id, p.name])),
+		Object.fromEntries(allItems.value.flatMap(p => p.variations?.map(v => [v.id, p.name + ' – ' + v.name]) ?? [])),
 		rules.value
 	)
 }