Fix #356 -- Download all tickets from an order

src/pretix/presale/templates/pretixpresale/event/order.html

@@ -73,6 +73,17 @@
                     You can download your tickets using the buttons below. Please have your ticket ready when entering the event.
                 {% endblocktrans %}
             </div>
+            {% if cart.positions|length > 1 %}
+                <p>
+                    {% trans "Download all tickets at once:" %}
+                    {% for b in download_buttons %}
+                        <a href="{% eventurl event "presale:event.order.download.combined" secret=order.secret order=order.code output=b.identifier %}"
+                                class="btn btn-default btn-sm" data-asyncdownload>
+                            <span class="fa fa-download"></span> {{ b.text }}
+                        </a>
+                    {% endfor %}
+                </p>
+            {% endif %}
         {% elif not download_buttons %}
             <div class="alert alert-info">
                 {% blocktrans trimmed with date=event.settings.ticket_download_date|date:"SHORT_DATE_FORMAT" %}

src/pretix/presale/urls.py

@@ -45,6 +45,9 @@ event_patterns = [
     url(r'^order/(?P<order>[^/]+)/(?P<secret>[A-Za-z0-9]+)/pay/change',
         pretix.presale.views.order.OrderPayChangeMethod.as_view(),
         name='event.order.pay.change'),
+    url(r'^order/(?P<order>[^/]+)/(?P<secret>[A-Za-z0-9]+)/download/(?P<output>[^/]+)$',
+        pretix.presale.views.order.OrderDownload.as_view(),
+        name='event.order.download.combined'),
     url(r'^order/(?P<order>[^/]+)/(?P<secret>[A-Za-z0-9]+)/download/(?P<position>[0-9]+)/(?P<output>[^/]+)$',
         pretix.presale.views.order.OrderDownload.as_view(),
         name='event.order.download'),

src/pretix/presale/views/order.py

@@ -1,3 +1,5 @@
+from datetime import timedelta
+
 from django.contrib import messages
 from django.db import transaction
 from django.db.models import Sum
@@ -9,12 +11,12 @@ from django.utils.translation import ugettext_lazy as _
 from django.views.generic import TemplateView, View
 
 from pretix.base.models import CachedTicket, Invoice, Order, OrderPosition
-from pretix.base.models.orders import InvoiceAddress
+from pretix.base.models.orders import CachedCombinedTicket, InvoiceAddress
 from pretix.base.services.invoices import (
     generate_cancellation, generate_invoice, invoice_pdf, invoice_qualified,
 )
 from pretix.base.services.orders import cancel_order
-from pretix.base.services.tickets import generate
+from pretix.base.services.tickets import generate, generate_order
 from pretix.base.signals import (
     register_payment_providers, register_ticket_outputs,
 )
@@ -508,7 +510,7 @@ class OrderDownload(EventViewMixin, OrderDetailMixin, View):
         if not self.output or not self.output.is_enabled:
             messages.error(request, _('You requested an invalid ticket output type.'))
             return redirect(self.get_order_url())
-        if not self.order or not self.order_position:
+        if not self.order or ('position' in kwargs and not self.order_position):
             raise Http404(_('Unknown order code or not authorized to access this order.'))
         if self.order.status != Order.STATUS_PAID:
             messages.error(request, _('Order is not paid.'))
@@ -519,6 +521,39 @@ class OrderDownload(EventViewMixin, OrderDetailMixin, View):
             messages.error(request, _('Ticket download is not (yet) enabled.'))
             return redirect(self.get_order_url())
 
+        if 'position' in kwargs:
+            return self._download_position()
+        else:
+            return self._download_order()
+
+    def _download_order(self):
+        try:
+            ct = CachedCombinedTicket.objects.filter(
+                order=self.order, provider=self.output.identifier
+            ).last()
+        except CachedCombinedTicket.DoesNotExist:
+            ct = None
+
+        if not ct:
+            ct = CachedCombinedTicket.objects.create(
+                order=self.order, provider=self.output.identifier,
+                extension='', type='', file=None)
+            generate_order.apply_async(args=(self.order.id, self.output.identifier))
+
+        if 'ajax' in self.request.GET:
+            return HttpResponse('1' if ct and ct.file else '0')
+        elif not ct.file:
+            if now() - ct.created > timedelta(minutes=110):
+                generate_order.apply_async(args=(self.order.id, self.output.identifier))
+            return render(self.request, "pretixbase/cachedfiles/pending.html", {})
+        else:
+            resp = FileResponse(ct.file.file, content_type=ct.type)
+            resp['Content-Disposition'] = 'attachment; filename="{}-{}-{}{}"'.format(
+                self.request.event.slug.upper(), self.order.code, self.output.identifier, ct.extension
+            )
+            return resp
+
+    def _download_position(self):
         try:
             ct = CachedTicket.objects.filter(
                 order_position=self.order_position, provider=self.output.identifier
@@ -532,10 +567,12 @@ class OrderDownload(EventViewMixin, OrderDetailMixin, View):
                 extension='', type='', file=None)
             generate.apply_async(args=(self.order_position.id, self.output.identifier))
 
-        if 'ajax' in request.GET:
+        if 'ajax' in self.request.GET:
             return HttpResponse('1' if ct and ct.file else '0')
         elif not ct.file:
-            return render(request, "pretixbase/cachedfiles/pending.html", {})
+            if now() - ct.created > timedelta(minutes=110):
+                generate.apply_async(args=(self.order_position.id, self.output.identifier))
+            return render(self.request, "pretixbase/cachedfiles/pending.html", {})
         else:
             resp = FileResponse(ct.file.file, content_type=ct.type)
             resp['Content-Disposition'] = 'attachment; filename="{}-{}-{}-{}{}"'.format(