CGM_Public/pretix_cgo
1
0
Fork 0
forked from CGM_Public/pretix_original
Code Pull Requests Actions Activity

Improve wording for cart-renew dialog (#5174)

Browse Source 
* Improve wording for cart-renew dialog

* remove duplication of static texts for dialog

Co-authored-by: luelista <weller@rami.io>

* Fix typo

Co-authored-by: Raphael Michel <michel@rami.io>

* Apply suggestions from code review

Co-authored-by: Richard Schreiber <schreiber@rami.io>

---------

Co-authored-by: luelista <weller@rami.io>
Co-authored-by: Raphael Michel <michel@rami.io>
This commit is contained in:
Richard Schreiber
2025-05-28 17:36:37 +02:00
committed by GitHub
parent fe0b8c9f97
commit e8ff743b76
3 changed files with 12 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/pretix/presale/templates/pretixpresale/event/fragment_cart.html
View File

@@ -506,7 +506,7 @@
</p>
<p>
<button class="btn btn-default" type="submit" id="cart-extend-button" aria-describedby="cart-deadline">
<i class="fa fa-refresh" aria-hidden="true"></i> {% trans "Extend reservation" %}
<i class="fa fa-refresh" aria-hidden="true"></i> {% trans "Renew reservation" %}
</button>
</p>
</form>

5
src/pretix/presale/templates/pretixpresale/fragment_modals.html
View File

@@ -44,9 +44,8 @@
</div>
{% enddialog %}
{% trans "Please let us know you're still there." as label_cart_extend_dialog %}
{% dialog "dialog-cart-extend" label_cart_extend_dialog "" icon="clock-o" alert=true %}
<p class="modal-card-confirm"><button class="btn btn-lg btn-primary">{% trans "Continue" %}</button></p>
{% dialog "dialog-cart-extend" "" "" icon="clock-o" alert=true %}
<p class="modal-card-confirm"><button class="btn btn-lg btn-primary">{% trans "Renew reservation" %}</button></p>
{% enddialog %}
<dialog id="lightbox-dialog" class="modal-card" role="alertdialog" aria-labelledby="lightbox-label">

12
src/pretix/static/pretixpresale/js/ui/cart.js
View File

@@ -56,7 +56,7 @@ var cart = {
} else {
if (diff_minutes !== cart._prev_diff_minutes) {
if (diff_minutes == 0) {
$("#cart-deadline").text(gettext("Your cart is about to expire. If you want to continue, please click here:"))
$("#cart-deadline").text(gettext("Your cart is about to expire."))
} else {
$("#cart-deadline").text(
cart._renewed_message + " " +
@@ -82,9 +82,15 @@ var cart = {
$("#cart-extend-button").toggle(can_extend_cart);
if (can_extend_cart && diff_total_seconds < 45) {
if (!cart._expiry_notified) cart.show_expiry_notification();
$("#dialog-cart-extend-title").text(already_expired
? gettext("Your cart has expired.")
: gettext("Your cart is about to expire."));
$("#dialog-cart-extend-description").text(already_expired
? gettext("Your cart has expired. If you want to continue, please click here:")
: gettext("Your cart is about to expire. If you want to continue, please click here:"));
? gettext("The items in your cart are no longer reserved for you. You can still complete your order as long as they're available.")
: gettext("Do you want to renew the reservation period?"));
$("#dialog-cart-extend .modal-card-confirm button").text(already_expired
? gettext("Continue")
: gettext("Renew reservation"));
}
},