Bank transfer: Discourage payments before an order code exists (Z#23135042) (#3692)

* Bank transfer: Discourage payments befor an order code exists

* Update src/pretix/plugins/banktransfer/templates/pretixplugins/banktransfer/checkout_payment_form.html

Co-authored-by: Mira <weller@rami.io>

---------

Co-authored-by: Mira <weller@rami.io>

src/pretix/plugins/banktransfer/templates/pretixplugins/banktransfer/checkout_confirm.html

@@ -2,11 +2,13 @@
 {% load ibanformat %}
 {% load bootstrap3 %}
 
+{% if details or code %}
     <p>{% blocktrans trimmed %}
         After completing your purchase, we will ask you to transfer the money to the following
         bank account, using a personal reference code:
     {% endblocktrans %}</p>
 
+    {% if not code %}<div class="user-select-none" data-toggle="tooltip" title="{% trans "Please do not yet start a payment. We'll assign you a personal reference code after you completed the order." %}">{% endif %}
     {% if settings.bank_details_type == "sepa" %}
         <dl class="dl-horizontal">
             <dt>{% trans "Account holder" %}: </dt><dd>{{ settings.bank_details_sepa_name }}</dd>
@@ -16,9 +18,9 @@
         </dl>
     {% endif %}
 
-{% if details %}
     {{ details|linebreaks }}
-{% endif %}
+    {% if not code %}</div>{% endif %}
+
     {% if code %}
         <dl class="dl-horizontal">
             <dt>{% trans "Reference code (important):" %} </dt><dd><strong>{{ code }}</strong></dd>
@@ -30,6 +32,12 @@
             </strong>
         </p>
     {% endif %}
+{% else %}
+    <p>{% blocktrans trimmed %}
+        After completing your purchase, we will ask you to transfer the money to our bank account, using a personal
+        reference code.
+    {% endblocktrans %}</p>
+{% endif %}
 {% if request.session.payment_banktransfer_send_invoice and request.session.payment_banktransfer_send_invoice_to %}
     <p>
         {% blocktrans trimmed with recipient=request.session.payment_banktransfer_send_invoice_to %}

src/pretix/plugins/banktransfer/templates/pretixplugins/banktransfer/checkout_payment_form.html

@@ -2,11 +2,13 @@
 {% load ibanformat %}
 {% load bootstrap3 %}
 
+{% if details or code %}
     <p>{% blocktrans trimmed %}
         After completing your purchase, we will ask you to transfer the money to the following
         bank account, using a personal reference code:
     {% endblocktrans %}</p>
 
+    {% if not code %}<div class="user-select-none" data-toggle="tooltip" title="{% trans "Please do not yet start a payment. We'll assign you a personal reference code after you completed the order." %}">{% endif %}
     {% if settings.bank_details_type == "sepa" %}
         <dl class="dl-horizontal">
             <dt>{% trans "Account holder" %}: </dt><dd>{{ settings.bank_details_sepa_name }}</dd>
@@ -16,9 +18,9 @@
         </dl>
     {% endif %}
 
-{% if details %}
     {{ details|linebreaks }}
-{% endif %}
+    {% if not code %}</div>{% endif %}
+
     {% if code %}
         <dl class="dl-horizontal">
             <dt>{% trans "Reference code (important):" %} </dt><dd><strong>{{ code }}</strong></dd>
@@ -30,6 +32,12 @@
             </strong>
         </p>
     {% endif %}
+{% else %}
+    <p>{% blocktrans trimmed %}
+        After completing your purchase, we will ask you to transfer the money to our bank account, using a personal
+        reference code.
+    {% endblocktrans %}</p>
+{% endif %}
 {% if form.fields %}
     <div class="col-md-12">
         {% bootstrap_form form layout='inline' %}

src/pretix/static/pretixpresale/scss/main.scss

@@ -482,6 +482,10 @@ h2 .label {
     }
 }
 
+.user-select-none {
+    user-select: none;
+}
+
 @for $i from 0 through 100 {
     .progress-bar-#{$i} { width: 1% * $i; }
 }