CGM_Public/pretix_cgo
1
0
Fork 0
forked from CGM_Public/pretix_original
Code Pull Requests Actions Activity

Fix race condition in formset validation

Browse Source
This commit is contained in:
Raphael Michel
2018-07-11 14:57:31 +02:00
parent 6b9c3ad4e7
commit e46b33544d
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/pretix/control/forms/item.py
View File

@@ -404,19 +404,20 @@ class ItemAddOnsFormSet(I18nFormSet):
def clean(self): def clean(self):
super().clean() super().clean()
categories = set() categories = set(self.queryset.values_list('addon_category_id', flat=True))
for i in range(0, self.total_form_count()): for i in range(0, self.total_form_count()):
form = self.forms[i] form = self.forms[i]
if self.can_delete: if self.can_delete:
if self._should_delete_form(form): if self._should_delete_form(form):
# This form is going to be deleted so any of its errors # This form is going to be deleted so any of its errors
# should not cause the entire formset to be invalid. # should not cause the entire formset to be invalid.
categories.remove(form.cleaned_data['addon_category'].pk)
continue continue
if form.cleaned_data['addon_category'] in categories: if form.cleaned_data['addon_category'].pk in categories:
raise ValidationError(_('You added the same add-on category twice')) raise ValidationError(_('You added the same add-on category twice'))
categories.add(form.cleaned_data['addon_category']) categories.add(form.cleaned_data['addon_category'].pk)
@property @property
def empty_form(self): def empty_form(self):