CGM_Public/pretix_cgo
1
0
Fork 0
forked from CGM_Public/pretix_original
Code Pull Requests Actions Activity

[A11y] Do not set autocomplete section if autocomplete is off (#5194)

Browse Source
This commit is contained in:
Raphael Michel
2025-06-03 11:08:17 +02:00
committed by GitHub
parent f600200ec6
commit d255c40a0b
1 changed files with 17 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
src/pretix/base/forms/questions.py
View File

@@ -182,7 +182,13 @@ class NamePartsWidget(forms.MultiWidget):
if self.field.required: if self.field.required:
these_attrs['required'] = 'required' these_attrs['required'] = 'required'
these_attrs.pop('data-no-required-attr', None) these_attrs.pop('data-no-required-attr', None)
these_attrs['autocomplete'] = (self.attrs.get('autocomplete', '') + ' ' + self.autofill_map.get(self.scheme['fields'][i][0], 'off')).strip()
autofill_section = self.attrs.get('autocomplete', '')
autofill_by_name_scheme = self.autofill_map.get(self.scheme['fields'][i][0], 'off')
if autofill_by_name_scheme == "off" or autofill_section.strip() == "off":
these_attrs['autocomplete'] = "off"
else:
these_attrs['autocomplete'] = (autofill_section + ' ' + autofill_by_name_scheme).strip()
these_attrs['data-size'] = self.scheme['fields'][i][2] these_attrs['data-size'] = self.scheme['fields'][i][2]
these_attrs['aria-label'] = self.scheme['fields'][i][1] these_attrs['aria-label'] = self.scheme['fields'][i][1]
else: else:
@@ -987,7 +993,11 @@ class BaseQuestionsForm(forms.Form):
for k, v in self.fields.items(): for k, v in self.fields.items():
if v.widget.attrs.get('autocomplete') or k == 'attendee_name_parts': if v.widget.attrs.get('autocomplete') or k == 'attendee_name_parts':
v.widget.attrs['autocomplete'] = 'section-{} '.format(self.prefix) + v.widget.attrs.get('autocomplete', '') autocomplete = v.widget.attrs.get('autocomplete', '')
if autocomplete.strip() == "off":
v.widget.attrs['autocomplete'] = 'off'
else:
v.widget.attrs['autocomplete'] = 'section-{} '.format(self.prefix) + autocomplete
def clean(self): def clean(self):
from pretix.base.addressvalidation import \ from pretix.base.addressvalidation import \
@@ -1201,7 +1211,11 @@ class BaseInvoiceAddressForm(forms.ModelForm):
for k, v in self.fields.items(): for k, v in self.fields.items():
if v.widget.attrs.get('autocomplete') or k == 'name_parts': if v.widget.attrs.get('autocomplete') or k == 'name_parts':
v.widget.attrs['autocomplete'] = 'section-invoice billing ' + v.widget.attrs.get('autocomplete', '') autocomplete = v.widget.attrs.get('autocomplete', '')
if autocomplete.strip() == "off":
v.widget.attrs['autocomplete'] = 'off'
else:
v.widget.attrs['autocomplete'] = 'section-invoice billing ' + autocomplete
def clean(self): def clean(self):
from pretix.base.addressvalidation import \ from pretix.base.addressvalidation import \