Never create implicit payments for orders that require approval

2018-12-14 10:42:08 +01:00
parent 04c3cffd43
commit cf4b2544f2
3 changed files with 38 additions and 2 deletions
--- a/src/pretix/base/services/orders.py
+++ b/src/pretix/base/services/orders.py
@@ -532,7 +532,7 @@ def _create_order(event: Event, email: str, positions: List[CartPosition], now_d
                fee.tax_rule = None  # TODO: deprecate
            fee.save()

-        if payment_provider:
+        if payment_provider and not order.require_approval:
            order.payments.create(
                state=OrderPayment.PAYMENT_STATE_CREATED,
                provider=payment_provider.identifier,