Store all check-in attempts, not only successful ones (#2074)

src/tests/api/test_checkin.py

@@ -432,6 +432,8 @@ def test_list_all_items_positions(token_client, organizer, event, clist, clist_a
             'list': clist_all.pk,
             'datetime': c.datetime.isoformat().replace('+00:00', 'Z'),
             'auto_checked_in': False,
+            'device': None,
+            'gate': None,
             'type': 'entry',
         }
     ]
@@ -472,6 +474,8 @@ def test_list_all_items_positions(token_client, organizer, event, clist, clist_a
             'list': clist_all.pk,
             'datetime': c.datetime.isoformat().replace('+00:00', 'Z'),
             'auto_checked_in': False,
+            'device': None,
+            'gate': None,
             'type': 'entry',
         }
     ]
@@ -1060,3 +1064,45 @@ def test_question_upload(token_client, organizer, clist, event, order, question)
     with scopes_disabled():
         assert order.positions.first().answers.get(question=question[0]).answer.startswith('file://')
         assert order.positions.first().answers.get(question=question[0]).file
+
+
+@pytest.mark.django_db
+def test_store_failed(token_client, organizer, clist, event, order):
+    with scopes_disabled():
+        p = order.positions.first()
+    resp = token_client.post('/api/v1/organizers/{}/events/{}/checkinlists/{}/failed_checkins/'.format(
+        organizer.slug, event.slug, clist.pk,
+    ), {
+        'raw_barcode': '123456',
+        'error_reason': 'invalid'
+    }, format='json')
+    assert resp.status_code == 201
+    with scopes_disabled():
+        assert Checkin.all.filter(successful=False).exists()
+
+    resp = token_client.post('/api/v1/organizers/{}/events/{}/checkinlists/{}/failed_checkins/'.format(
+        organizer.slug, event.slug, clist.pk,
+    ), {
+        'raw_barcode': '123456',
+        'position': p.pk,
+        'error_reason': 'unpaid'
+    }, format='json')
+    assert resp.status_code == 201
+    with scopes_disabled():
+        assert p.all_checkins.filter(successful=False).count() == 1
+
+    resp = token_client.post('/api/v1/organizers/{}/events/{}/checkinlists/{}/failed_checkins/'.format(
+        organizer.slug, event.slug, clist.pk,
+    ), {
+        'position': p.pk,
+        'error_reason': 'unpaid'
+    }, format='json')
+    assert resp.status_code == 400
+
+    resp = token_client.post('/api/v1/organizers/{}/events/{}/checkinlists/{}/failed_checkins/'.format(
+        organizer.slug, event.slug, clist.pk,
+    ), {
+        'raw_barcode': '123456',
+        'error_reason': 'unknown'
+    }, format='json')
+    assert resp.status_code == 400

src/tests/api/test_orders.py

@@ -865,11 +865,14 @@ def test_orderposition_list(token_client, organizer, event, order, item, subeven
     with scopes_disabled():
         cl = event.checkin_lists.create(name="Default")
         c = op.checkins.create(datetime=datetime.datetime(2017, 12, 26, 10, 0, 0, tzinfo=UTC), list=cl)
-    res['checkins'] = [{
+        op.checkins.create(datetime=datetime.datetime(2017, 12, 26, 10, 0, 0, tzinfo=UTC), list=cl, successful=False)
+    res['checkins'] = [{  # successful only
         'id': c.pk,
         'datetime': '2017-12-26T10:00:00Z',
         'list': cl.pk,
         'auto_checked_in': False,
+        'device': None,
+        'gate': None,
         'type': 'entry'
     }]
     resp = token_client.get(

src/tests/api/test_permissions.py

@@ -157,10 +157,13 @@ event_permission_sub_urls = [
     ('post', 'can_change_orders', 'orders/ABC12/refunds/1/process/', 404),
     ('post', 'can_change_orders', 'orders/ABC12/refunds/1/done/', 404),
     ('get', 'can_view_orders', 'checkinlists/', 200),
+    ('post', 'can_change_orders', 'checkinlists/1/failed_checkins/', 400),
     ('post', 'can_change_event_settings', 'checkinlists/', 400),
     ('put', 'can_change_event_settings', 'checkinlists/1/', 404),
     ('patch', 'can_change_event_settings', 'checkinlists/1/', 404),
     ('delete', 'can_change_event_settings', 'checkinlists/1/', 404),
+    ('get', 'can_view_orders', 'checkinlists/1/positions/', 404),
+    ('post', 'can_change_orders', 'checkinlists/1/positions/3/redeem/', 404),
     ('post', 'can_create_events', 'clone/', 400),
     ('get', 'can_view_orders', 'cartpositions/', 200),
     ('get', 'can_view_orders', 'cartpositions/1/', 404),

src/tests/control/test_permissions.py

@@ -157,6 +157,7 @@ event_urls = [
     "orders/ABC/",
     "orders/",
     "orders/import/",
+    "checkins/",
     "checkinlists/",
     "checkinlists/1/",
     "checkinlists/1/change",
@@ -349,6 +350,7 @@ event_permission_urls = [
     ("can_view_orders", "waitinglist/", 200),
     ("can_change_orders", "waitinglist/auto_assign", 405),
     ("can_change_orders", "waitinglist/action", 405),
+    ("can_view_orders", "checkins/", 200),
     ("can_view_orders", "checkinlists/", 200),
     ("can_view_orders", "checkinlists/1/", 404),
     ("can_change_event_settings", "checkinlists/add", 200),

src/tests/plugins/sendmail/test_sendmail.py

@@ -427,6 +427,7 @@ def test_sendmail_attendee_checkin_filter(logged_in_client, sendmail_url, event,
                                       },
                                      follow=True)
     assert response.status_code == 200
+    print(response.rendered_content)
     assert 'alert-success' in response.rendered_content
     assert len(djmail.outbox) == 1
     assert djmail.outbox[0].to == ['attendee1@dummy.test']