Offer download options per position, not per order

src/pretix/base/migrations/0044_auto_20161101_1610.py

@@ -0,0 +1,34 @@
+# -*- coding: utf-8 -*-
+# Generated by Django 1.10.2 on 2016-11-01 16:10
+from __future__ import unicode_literals
+
+import django.db.models.deletion
+from django.db import migrations, models
+
+
+def forwards(apps, schema_editor):
+    CachedTicket = apps.get_model('pretixbase', 'CachedTicket')
+    CachedTicket.objects.all().delete()
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ('pretixbase', '0043_globalsetting'),
+    ]
+
+    operations = [
+        migrations.RunPython(
+            forwards, migrations.RunPython.noop
+        ),
+        migrations.RemoveField(
+            model_name='cachedticket',
+            name='order',
+        ),
+        migrations.AddField(
+            model_name='cachedticket',
+            name='order_position',
+            field=models.ForeignKey(default=None, on_delete=django.db.models.deletion.CASCADE, to='pretixbase.OrderPosition'),
+            preserve_default=False,
+        ),
+    ]

src/pretix/base/models/orders.py

@@ -309,12 +309,6 @@ class Order(LoggedModel):
         return True
 
 
-class CachedTicket(models.Model):
-    order = models.ForeignKey(Order, on_delete=models.CASCADE)
-    cachedfile = models.ForeignKey(CachedFile, on_delete=models.CASCADE, null=True)
-    provider = models.CharField(max_length=255)
-
-
 class QuestionAnswer(models.Model):
     """
     The answer to a Question, connected to an OrderPosition or CartPosition.
@@ -554,3 +548,9 @@ class InvoiceAddress(models.Model):
     city = models.CharField(max_length=255, verbose_name=_('City'), blank=False)
     country = models.CharField(max_length=255, verbose_name=_('Country'), blank=False)
     vat_id = models.CharField(max_length=255, blank=True, verbose_name=_('VAT ID'))
+
+
+class CachedTicket(models.Model):
+    order_position = models.ForeignKey(OrderPosition, on_delete=models.CASCADE)
+    cachedfile = models.ForeignKey(CachedFile, on_delete=models.CASCADE, null=True)
+    provider = models.CharField(max_length=255)

src/pretix/base/services/tickets.py

@@ -6,7 +6,7 @@ from django.utils.translation import ugettext as _
 
 from pretix.base.i18n import language
 from pretix.base.models import (
-    CachedFile, CachedTicket, Event, Order, cachedfile_name,
+    CachedFile, CachedTicket, Event, Order, OrderPosition, cachedfile_name,
 )
 from pretix.base.signals import register_ticket_outputs
 from pretix.celery import app
@@ -14,23 +14,23 @@ from pretix.helpers.database import rolledback_transaction
 
 
 @app.task
-def generate(order: str, provider: str):
-    order = Order.objects.select_related('event').get(id=order)
-    ct = CachedTicket.objects.get_or_create(order=order, provider=provider)[0]
+def generate(order_position: str, provider: str):
+    order_position = OrderPosition.objects.select_related('order', 'order__event').get(id=order_position)
+    ct = CachedTicket.objects.get_or_create(order_position=order_position, provider=provider)[0]
     if not ct.cachedfile:
         cf = CachedFile()
         cf.date = now()
-        cf.expires = order.event.date_from + timedelta(days=30)
+        cf.expires = order_position.order.event.date_from + timedelta(days=30)
         cf.save()
         ct.cachedfile = cf
         ct.save()
 
-    with language(order.locale):
-        responses = register_ticket_outputs.send(order.event)
+    with language(order_position.order.locale):
+        responses = register_ticket_outputs.send(order_position.order.event)
         for receiver, response in responses:
-            prov = response(order.event)
+            prov = response(order_position.order.event)
             if prov.identifier == provider:
-                ct.cachedfile.filename, ct.cachedfile.type, data = prov.generate(order)
+                ct.cachedfile.filename, ct.cachedfile.type, data = prov.generate(order_position)
                 ct.cachedfile.file.save(cachedfile_name(ct.cachedfile, ct.cachedfile.filename), ContentFile(data))
                 ct.cachedfile.save()
 
@@ -49,10 +49,10 @@ def preview(event: int, provider: str):
                                     email='sample@pretix.eu',
                                     expires=now(), code="PREVIEW1234", total=119)
 
-        order.positions.create(item=item, attendee_name=_("John Doe"), price=item.default_price)
+        p = order.positions.create(item=item, attendee_name=_("John Doe"), price=item.default_price)
 
         responses = register_ticket_outputs.send(event)
         for receiver, response in responses:
             prov = response(event)
             if prov.identifier == provider:
-                return prov.generate(order)
+                return prov.generate(p)

src/pretix/base/ticketoutput.py

@@ -5,7 +5,7 @@ from django import forms
 from django.http import HttpRequest
 from django.utils.translation import ugettext_lazy as _
 
-from pretix.base.models import Event, Order
+from pretix.base.models import Event, OrderPosition
 from pretix.base.settings import SettingsSandbox
 
 
@@ -29,7 +29,7 @@ class BaseTicketOutput:
         """
         return self.settings.get('_enabled', as_type=bool)
 
-    def generate(self, order: Order) -> Tuple[str, str, str]:
+    def generate(self, order: OrderPosition) -> Tuple[str, str, str]:
         """
         This method should generate the download file and return a tuple consisting of a
         filename, a file type and file content.
@@ -106,11 +106,3 @@ class BaseTicketOutput:
         The text on the download button in the frontend.
         """
         return _('Download ticket')
-
-    @property
-    def download_button_icon(self) -> str:
-        """
-        The name of the FontAwesome icon on the download button in the frontend
-        (without the fa- prefix).
-        """
-        return None