From 881f0e04a0b953c30b1ae25fe9f8ed68a35c024d Mon Sep 17 00:00:00 2001
From: Raphael Michel <michel@rami.io>
Date: Mon, 7 Jun 2021 12:41:03 +0200
Subject: [PATCH] Do not offer to create a new customer account if a membership
 is required

---
 src/pretix/presale/checkoutflow.py            |  9 +++
 .../event/checkout_customer.html              | 58 ++++++++++---------
 2 files changed, 39 insertions(+), 28 deletions(-)

diff --git a/src/pretix/presale/checkoutflow.py b/src/pretix/presale/checkoutflow.py
index 81b54c62c..7595c9b33 100644
--- a/src/pretix/presale/checkoutflow.py
+++ b/src/pretix/presale/checkoutflow.py
@@ -254,6 +254,14 @@ class CustomerStep(QuestionsViewMixin, CartMixin, TemplateFlowStep):
             field.widget.is_required = False
         return f
 
+    @cached_property
+    def signup_allowed(self):
+        return not any(
+            p.item.require_membership or
+            (p.variation and p.variation.require_membership)
+            for p in self.positions
+        )
+
     @cached_property
     def guest_allowed(self):
         return not any(
@@ -330,6 +338,7 @@ class CustomerStep(QuestionsViewMixin, CartMixin, TemplateFlowStep):
             self.cart_session.get('customer_mode', 'login' if self.request.customer else '')
         )
         ctx['guest_allowed'] = self.guest_allowed
+        ctx['signup_allowed'] = self.signup_allowed
 
         if 'customer' in self.cart_session:
             try:
diff --git a/src/pretix/presale/templates/pretixpresale/event/checkout_customer.html b/src/pretix/presale/templates/pretixpresale/event/checkout_customer.html
index 0b9e7bbef..de448d462 100644
--- a/src/pretix/presale/templates/pretixpresale/event/checkout_customer.html
+++ b/src/pretix/presale/templates/pretixpresale/event/checkout_customer.html
@@ -14,7 +14,7 @@
                         <h4 class="panel-title">
                             <input type="radio" name="customer_mode" value="login"
                                     data-parent="#customer"
-                                    {% if selected == "login" %}checked="checked"{% endif %}
+                                    {% if selected == "login" or not signup_allowed %}checked="checked"{% endif %}
                                     data-toggle="radiocollapse" data-target="#customer_login"/>
                             <strong>
                                 {% trans "Log in with a customer account" %}
@@ -23,7 +23,7 @@
                     </div>
                 </label>
                 <div id="customer_login"
-                        class="panel-collapse collapsed {% if selected == "login" %}in{% endif %}">
+                        class="panel-collapse collapsed {% if selected == "login" or not signup_allowed %}in{% endif %}">
                     <div class="panel-body form-horizontal">
                         {% if customer %}
                             <p>
@@ -65,34 +65,36 @@
                     </div>
                 </div>
             </div>
-            <div class="panel panel-default">
-                <label class="accordion-radio">
-                    <div class="panel-heading">
-                        <h4 class="panel-title">
-                            <input type="radio" name="customer_mode" value="register"
-                                    data-parent="#customer"
-                                    {% if selected == "register" %}checked="checked"{% endif %}
-                                    data-toggle="radiocollapse" data-target="#customer_register"/>
-                            <strong>
-                                {% trans "Create a new customer account" %}
-                            </strong>
-                        </h4>
-                    </div>
-                </label>
-                <div id="customer_register"
-                        class="panel-collapse collapsed {% if selected == "register" %}in{% endif %}">
-                    <div class="panel-body form-horizontal">
-                        {% bootstrap_form register_form layout="checkout" %}
-                        <p>
-                            {% blocktrans trimmed with org=request.organizer.name %}
-                                We will send you an email with a link to activate your account and set a password, so
-                                you can use the account for future orders at {{ org }}. You can still go ahead with this
-                                purchase before you received the email.
-                            {% endblocktrans %}
-                        </p>
+            {% if signup_allowed %}
+                <div class="panel panel-default">
+                    <label class="accordion-radio">
+                        <div class="panel-heading">
+                            <h4 class="panel-title">
+                                <input type="radio" name="customer_mode" value="register"
+                                        data-parent="#customer"
+                                        {% if selected == "register" %}checked="checked"{% endif %}
+                                        data-toggle="radiocollapse" data-target="#customer_register"/>
+                                <strong>
+                                    {% trans "Create a new customer account" %}
+                                </strong>
+                            </h4>
+                        </div>
+                    </label>
+                    <div id="customer_register"
+                            class="panel-collapse collapsed {% if selected == "register" %}in{% endif %}">
+                        <div class="panel-body form-horizontal">
+                            {% bootstrap_form register_form layout="checkout" %}
+                            <p>
+                                {% blocktrans trimmed with org=request.organizer.name %}
+                                    We will send you an email with a link to activate your account and set a password, so
+                                    you can use the account for future orders at {{ org }}. You can still go ahead with this
+                                    purchase before you received the email.
+                                {% endblocktrans %}
+                            </p>
+                        </div>
                     </div>
                 </div>
-            </div>
+            {% endif %}
             {% if guest_allowed %}
                 <div class="panel panel-default">
                     <label class="accordion-radio">