CGM_Public/pretix_cgo
1
0
Fork 0
forked from CGM_Public/pretix_original
Code Pull Requests Actions Activity

Avoid duplicate order position secrets

Browse Source
This commit is contained in:
Raphael Michel
2016-12-19 23:13:14 +01:00
parent cfda772133
commit 852bc6c128
2 changed files with 13 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/pretix/base/models/orders.py
View File

@@ -495,6 +495,9 @@ class OrderPosition(AbstractPosition):
def save(self, *args, **kwargs): def save(self, *args, **kwargs):
if self.tax_rate is None: if self.tax_rate is None:
self._calculate_tax() self._calculate_tax()
if self.pk is None:
while OrderPosition.objects.filter(secret=self.secret).exists():
self.secret = generate_position_secret()
return super().save(*args, **kwargs) return super().save(*args, **kwargs)

10
src/tests/base/test_models.py
View File

@@ -577,6 +577,16 @@ class OrderTestCase(BaseQuotaTestCase):
variation=None, price=23) variation=None, price=23)
assert self.order.can_user_cancel is False assert self.order.can_user_cancel is False
def test_no_duplicate_position_secret(self):
item1 = Item.objects.create(event=self.event, name="Ticket", default_price=23,
admission=True, allow_cancel=False)
p1 = OrderPosition.objects.create(order=self.order, item=item1, secret='ABC',
variation=None, price=23)
p2 = OrderPosition.objects.create(order=self.order, item=item1, secret='ABC',
variation=None, price=23)
assert p1.secret != p2.secret
assert self.order.can_user_cancel is False
class ItemCategoryTest(TestCase): class ItemCategoryTest(TestCase):
""" """