CGM_Public/pretix_cgo
1
0
Fork 0
forked from CGM_Public/pretix_original
Code Pull Requests Actions Activity

Protect against empty orders

Browse Source
This commit is contained in:
Raphael Michel
2016-12-21 16:28:33 +01:00
parent 852bc6c128
commit 7639ef9a42
1 changed files with 3 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/pretix/base/services/orders.py
View File

@@ -43,6 +43,7 @@ error_messages = {
'price_changed': _('The price of some of the items in your cart has changed in the ' 'price_changed': _('The price of some of the items in your cart has changed in the '
'meantime. Please see below for details.'), 'meantime. Please see below for details.'),
'internal': _("An internal error occured, please try again."), 'internal': _("An internal error occured, please try again."),
'empty': _("Your cart is empty."),
'busy': _('We were not able to process your request completely as the ' 'busy': _('We were not able to process your request completely as the '
'server was too busy. Please try again.'), 'server was too busy. Please try again.'),
'not_started': _('The presale period for this event has not yet started.'), 'not_started': _('The presale period for this event has not yet started.'),
@@ -345,6 +346,8 @@ def _perform_order(event: str, payment_provider: str, position_ids: List[str],
with event.lock() as now_dt: with event.lock() as now_dt:
positions = list(CartPosition.objects.filter( positions = list(CartPosition.objects.filter(
id__in=position_ids).select_related('item', 'variation')) id__in=position_ids).select_related('item', 'variation'))
if len(positions) == 0:
raise OrderError(error_messages['empty'])
if len(position_ids) != len(positions): if len(position_ids) != len(positions):
raise OrderError(error_messages['internal']) raise OrderError(error_messages['internal'])
_check_positions(event, now_dt, positions) _check_positions(event, now_dt, positions)