Remove hack for gift card exporters, it's not required

src/pretix/base/exporters/orderlist.py

@@ -884,8 +884,7 @@ class QuotaListExporter(ListExporter):
         return '{}_quotas'.format(self.event.slug)
 
 
-def generate_GiftCardTransactionListExporter(organizer):  # hackhack
-    class GiftcardTransactionListExporter(ListExporter):
+class GiftcardTransactionListExporter(ListExporter):
     identifier = 'giftcardtransactionlist'
     verbose_name = gettext_lazy('Gift card transactions')
 
@@ -910,7 +909,7 @@ def generate_GiftCardTransactionListExporter(organizer):  # hackhack
 
     def iterate_list(self, form_data):
         qs = GiftCardTransaction.objects.filter(
-                card__issuer=organizer,
+            card__issuer=self.organizer,
         ).order_by('datetime').select_related('card', 'order', 'order__event')
 
         if form_data.get('date_from'):
@@ -952,8 +951,7 @@ def generate_GiftCardTransactionListExporter(organizer):  # hackhack
             yield row
 
     def get_filename(self):
-            return '{}_giftcardtransactions'.format(organizer.slug)
-    return GiftcardTransactionListExporter
+        return '{}_giftcardtransactions'.format(self.organizer.slug)
 
 
 class GiftcardRedemptionListExporter(ListExporter):
@@ -1000,8 +998,7 @@ class GiftcardRedemptionListExporter(ListExporter):
             return '{}_giftcardredemptions'.format(self.event.slug)
 
 
-def generate_GiftCardListExporter(organizer):  # hackhack
-    class GiftcardListExporter(ListExporter):
+class GiftcardListExporter(ListExporter):
     identifier = 'giftcardlist'
     verbose_name = gettext_lazy('Gift cards')
 
@@ -1043,7 +1040,7 @@ def generate_GiftCardListExporter(organizer):  # hackhack
             card=OuterRef('pk'),
             datetime__lte=form_data['date']
         ).order_by().values('card').annotate(s=Sum('value')).values('s')
-            qs = organizer.issued_gift_cards.filter(
+        qs = self.organizer.issued_gift_cards.filter(
             issuance__lte=form_data['date']
         ).annotate(
             cached_value=Coalesce(Subquery(s), Decimal('0.00')),
@@ -1105,9 +1102,7 @@ def generate_GiftCardListExporter(organizer):  # hackhack
             yield row
 
     def get_filename(self):
-            return '{}_giftcards'.format(organizer.slug)
-
-    return GiftcardListExporter
+        return '{}_giftcards'.format(self.organizer.slug)
 
 
 @receiver(register_data_exporters, dispatch_uid="exporter_orderlist")
@@ -1147,9 +1142,9 @@ def register_multievent_i_giftcardredemptionlist_exporter(sender, **kwargs):
 
 @receiver(register_multievent_data_exporters, dispatch_uid="multiexporter_giftcardlist")
 def register_multievent_i_giftcardlist_exporter(sender, **kwargs):
-    return generate_GiftCardListExporter(sender)
+    return GiftcardListExporter
 
 
 @receiver(register_multievent_data_exporters, dispatch_uid="multiexporter_giftcardtransactionlist")
 def register_multievent_i_giftcardtransactionlist_exporter(sender, **kwargs):
-    return generate_GiftCardTransactionListExporter(sender)
+    return GiftcardTransactionListExporter