CGM_Public/pretix_cgo
1
0
Fork 0
forked from CGM_Public/pretix_original
Code Pull Requests Actions Activity

Fix crash on VAT IDs with missing country prefix

Browse Source
This commit is contained in:
Raphael Michel
2022-08-14 21:44:50 +02:00
parent b5e5796549
commit 65b4741e27
2 changed files with 10 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/pretix/base/services/tax.py
View File

@@ -94,6 +94,10 @@ def _validate_vat_id_NO(vat_id, country_code):
def _validate_vat_id_EU(vat_id, country_code): def _validate_vat_id_EU(vat_id, country_code):
# Inspired by vat_moss library # Inspired by vat_moss library
vat_id = vat_moss.id.normalize(vat_id) vat_id = vat_moss.id.normalize(vat_id)
if not vat_id or len(vat_id) < 3:
raise VATIDFinalError(error_messages['invalid'])
number = vat_id[2:] number = vat_id[2:]
if vat_id[:2] != cc_to_vat_prefix(country_code): if vat_id[:2] != cc_to_vat_prefix(country_code):

6
src/tests/base/test_vat_id_validation.py
View File

@@ -16,6 +16,12 @@ def test_eu_invalid_format():
validate_vat_id('AT12345', 'AT') validate_vat_id('AT12345', 'AT')
@responses.activate
def test_eu_no_prefix():
with pytest.raises(VATIDFinalError):
validate_vat_id('12345', 'AT')
@responses.activate @responses.activate
def test_eu_country_mismatch(): def test_eu_country_mismatch():
with pytest.raises(VATIDFinalError): with pytest.raises(VATIDFinalError):