CGM_Public/pretix_cgo
1
0
Fork 0
forked from CGM_Public/pretix_original
Code Pull Requests Actions Activity

Stripe: Prevent race condition between ReturnView and webhook

Browse Source
This commit is contained in:
Raphael Michel
2019-01-03 09:34:15 +01:00
parent 82e3359b40
commit 654be0db34
1 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/pretix/plugins/stripe/views.py
View File

@@ -429,6 +429,12 @@ class ReturnView(StripeOrderView, View):
finally: finally:
if 'payment_stripe_token' in request.session: if 'payment_stripe_token' in request.session:
del request.session['payment_stripe_token'] del request.session['payment_stripe_token']
elif src.status == 'consumed' and (self.payment.info_data.get('id', '').startswith('py_') or
self.payment.info_data.get('id', '').startswith('ch_')):
# Webhook was faster, wow! ;)
if 'payment_stripe_token' in request.session:
del request.session['payment_stripe_token']
return self._redirect_to_order()
else: else:
self.payment.state = OrderPayment.PAYMENT_STATE_FAILED self.payment.state = OrderPayment.PAYMENT_STATE_FAILED
self.payment.info = str(src) self.payment.info = str(src)