From 5e3a8325ca5b567fb11dd4433638f48bde8b0e96 Mon Sep 17 00:00:00 2001
From: FlaviaBastos <FlaviaBastos@users.noreply.github.com>
Date: Wed, 5 Oct 2016 10:17:54 -0600
Subject: [PATCH] Fix #155 -- Remove javascript URIs for CSP (#261)

* remove javascript URIs for CSP

#155

* remove javascript URIs for CSP
Issue 155

Combining js error handling files.
---
 src/pretix/base/templates/400.html      | 6 +++---
 src/pretix/base/templates/403.html      | 6 +++---
 src/pretix/base/templates/404.html      | 4 ++--
 src/pretix/base/templates/500.html      | 6 +++---
 src/pretix/base/templates/csrffail.html | 4 ++--
 src/pretix/base/templates/error.html    | 1 +
 src/static/pretixbase/js/errors.js      | 5 +++++
 7 files changed, 19 insertions(+), 13 deletions(-)
 create mode 100644 src/static/pretixbase/js/errors.js

diff --git a/src/pretix/base/templates/400.html b/src/pretix/base/templates/400.html
index ea65f5898..274850d43 100644
--- a/src/pretix/base/templates/400.html
+++ b/src/pretix/base/templates/400.html
@@ -7,7 +7,7 @@
     <p>{% trans "We were unable to parse your request." %}</p>
     <p>{{ exception }}</p>
     <p class="links">
-        <a href="javascript:history.back()">{% trans "Take a step back" %}</a>
-        &middot; <a href="javascript:location.reload()">{% trans "Try again" %}</a>
+        <a id='goback' href='#'>{% trans "Take a step back" %}</a>
+        &middot; <a id='reload' href='#'>{% trans "Try again" %}</a>
     </p>
-{% endblock %}
\ No newline at end of file
+{% endblock %}
diff --git a/src/pretix/base/templates/403.html b/src/pretix/base/templates/403.html
index 2d39c0aa2..42280eae5 100644
--- a/src/pretix/base/templates/403.html
+++ b/src/pretix/base/templates/403.html
@@ -7,7 +7,7 @@
     <p>{% trans "You do not have access to this page." %}</p>
     <p>{{ exception }}</p>
     <p class="links">
-        <a href="javascript:history.back()">{% trans "Take a step back" %}</a>
-        &middot; <a href="javascript:location.reload()">{% trans "Try again" %}</a>
+        <a id='goback' href='#'>{% trans "Take a step back" %}</a>
+        &middot; <a id='reload' href='#'>{% trans "Try again" %}</a>
     </p>
-{% endblock %}
\ No newline at end of file
+{% endblock %}
diff --git a/src/pretix/base/templates/404.html b/src/pretix/base/templates/404.html
index 943af33de..13d84db87 100644
--- a/src/pretix/base/templates/404.html
+++ b/src/pretix/base/templates/404.html
@@ -7,6 +7,6 @@
     <p>{% trans "I'm afraid we could not find the the resource you requested." %}</p>
     <p>{{ exception }}</p>
     <p class="links">
-        <a href="javascript:history.back()">{% trans "Take a step back" %}</a>
+        <a id='goback' href='#'>{% trans "Take a step back" %}</a>
     </p>
-{% endblock %}
\ No newline at end of file
+{% endblock %}
diff --git a/src/pretix/base/templates/500.html b/src/pretix/base/templates/500.html
index 607bd8973..51a67b211 100644
--- a/src/pretix/base/templates/500.html
+++ b/src/pretix/base/templates/500.html
@@ -8,7 +8,7 @@
     <p>{% trans "If this problem persists, please contact us." %}</p>
     <p>{{ exception }}</p>
     <p class="links">
-        <a href="javascript:history.back()">{% trans "Take a step back" %}</a>
-        &middot; <a href="javascript:location.reload()">{% trans "Try again" %}</a>
+        <a id='goback' href='#'>{% trans "Take a step back" %}</a>
+        &middot; <a id='reload' href='#'>{% trans "Try again" %}</a>
     </p>
-{% endblock %}
\ No newline at end of file
+{% endblock %}
diff --git a/src/pretix/base/templates/csrffail.html b/src/pretix/base/templates/csrffail.html
index 730f6df6e..59fe8d60b 100644
--- a/src/pretix/base/templates/csrffail.html
+++ b/src/pretix/base/templates/csrffail.html
@@ -19,6 +19,6 @@
         {% endblocktrans %}</p>
     {% endif %}
     <p class="links">
-        <a href="javascript:history.back()">{% trans "Take a step back" %}</a>
+        <a id='goback' href='#'>{% trans "Take a step back" %}</a>
     </p>
-{% endblock %}
\ No newline at end of file
+{% endblock %}
diff --git a/src/pretix/base/templates/error.html b/src/pretix/base/templates/error.html
index e752c8836..eebd19498 100644
--- a/src/pretix/base/templates/error.html
+++ b/src/pretix/base/templates/error.html
@@ -16,4 +16,5 @@
     {% block content %}{% endblock %}
 </div>
 </body>
+<script src="{% static "pretixbase/js/errors.js" %}"></script>
 </html>
diff --git a/src/static/pretixbase/js/errors.js b/src/static/pretixbase/js/errors.js
new file mode 100644
index 000000000..016d48798
--- /dev/null
+++ b/src/static/pretixbase/js/errors.js
@@ -0,0 +1,5 @@
+document.getElementById('goback').onclick =
+   function() {window.history.back()};
+
+document.getElementById('reload').onclick =
+ function() {window.location.reload(true)};