Fix use of shadowed variable name

This commit is contained in:
Raphael Michel
2022-11-23 21:43:05 +01:00
parent 0b0ecf22bf
commit 5858ed8d5c

View File

@@ -1306,13 +1306,13 @@ class PaymentStep(CartMixin, TemplateFlowStep):
return False return False
used_providers = {p['provider'] for p in self.cart_session.get('payments', [])} used_providers = {p['provider'] for p in self.cart_session.get('payments', [])}
for p in self.request.event.get_payment_providers().values(): for provider in self.request.event.get_payment_providers().values():
if p.is_implicit(request) if callable(p.is_implicit) else p.is_implicit: if provider.is_implicit(request) if callable(provider.is_implicit) else provider.is_implicit:
if self._is_allowed(p, request): if self._is_allowed(provider, request):
self.cart_session['payments'] = [ self.cart_session['payments'] = [
{ {
'id': str(uuid.uuid4()), 'id': str(uuid.uuid4()),
'provider': p.identifier, 'provider': provider.identifier,
'multi_use_supported': False, 'multi_use_supported': False,
'min_value': None, 'min_value': None,
'max_value': None, 'max_value': None,
@@ -1320,9 +1320,9 @@ class PaymentStep(CartMixin, TemplateFlowStep):
} }
] ]
return False return False
elif p.identifier in used_providers: elif provider.identifier in used_providers:
# is_allowed might have changed, e.g. after add-on selection # is_allowed might have changed, e.g. after add-on selection
self.cart_session['payments'] = [p for p in self.cart_session['payments'] if p['provider'] != p.identifier] self.cart_session['payments'] = [p for p in self.cart_session['payments'] if p['provider'] != provider.identifier]
return True return True