From 563583cd36c651c1bb0ac35f1397a17d5336a88c Mon Sep 17 00:00:00 2001
From: Richard Schreiber <schreiber@rami.io>
Date: Tue, 24 Oct 2023 10:10:46 +0200
Subject: [PATCH] Improve help texts when deleting questions (Z#23134288)

---
 .../templates/pretixcontrol/items/question_delete.html | 10 +++++++---
 src/pretix/control/views/item.py                       |  5 +++++
 2 files changed, 12 insertions(+), 3 deletions(-)

diff --git a/src/pretix/control/templates/pretixcontrol/items/question_delete.html b/src/pretix/control/templates/pretixcontrol/items/question_delete.html
index 36aaf3e88..5119a58de 100644
--- a/src/pretix/control/templates/pretixcontrol/items/question_delete.html
+++ b/src/pretix/control/templates/pretixcontrol/items/question_delete.html
@@ -8,9 +8,13 @@
 		{% csrf_token %}
 		<p>{% blocktrans %}Are you sure you want to delete the question <strong>{{ question }}</strong>?{% endblocktrans %}</p>
 		{% if dependent|length > 0 %}
-			<p>{% blocktrans %}All answers to the question given by the buyers of the following products will be <strong>lost</strong>.{% endblocktrans %}</p>
+			<div class="alert alert-warning">
+				<p>{% blocktrans %}All answers to the question given by the buyers of the following products will be <strong>lost</strong>.{% endblocktrans %}
+					{% blocktrans with url=edit_url|add:"#tab-0-1-open" %}If you want to keep the answers, <a href="{{url}}">edit the question</a> and set it to hidden.{% endblocktrans %}
+				</p>
+			</div>
 			{% for item in dependent %}
-				<li><a href="{% url "control:event.item" organizer=request.event.organizer.slug event=request.event.slug item=item.pk %}">{{ item.name }}</a></li>
+				<li><a href="{% url "control:event.item" organizer=request.event.organizer.slug event=request.event.slug item=item.pk %}">{{ item }}</a></li>
 			{% endfor %}
 		{% endif %}
 		<div class="form-group submit-group">
@@ -18,7 +22,7 @@
                 {% trans "Cancel" %}
             </a>
             <button type="submit" class="btn btn-danger btn-save">
-                {% trans "Delete" %}
+                {% trans "Delete question and all answers" %}
             </button>
 		</div>
 	</form>
diff --git a/src/pretix/control/views/item.py b/src/pretix/control/views/item.py
index 02deb3fc6..e1fa7aece 100644
--- a/src/pretix/control/views/item.py
+++ b/src/pretix/control/views/item.py
@@ -573,6 +573,11 @@ class QuestionDelete(EventPermissionRequiredMixin, CompatDeleteView):
     def get_context_data(self, *args, **kwargs) -> dict:
         context = super().get_context_data(*args, **kwargs)
         context['dependent'] = list(self.get_object().items.all())
+        context['edit_url'] = reverse('control:event.items.questions.edit', kwargs={
+            'organizer': self.request.event.organizer.slug,
+            'event': self.request.event.slug,
+            'question': self.get_object().pk,
+        })
         return context
 
     @transaction.atomic