From 44afe9e193c851c9fc63471d26ff306b76057b81 Mon Sep 17 00:00:00 2001
From: Mira Weller <weller@rami.io>
Date: Tue, 30 Apr 2024 20:49:16 +0200
Subject: [PATCH] Improve form/error handling

---
 .../templates/pretixpresale/event/timemachine.html       | 9 ++++++---
 src/pretix/presale/views/event.py                        | 4 +++-
 2 files changed, 9 insertions(+), 4 deletions(-)

diff --git a/src/pretix/presale/templates/pretixpresale/event/timemachine.html b/src/pretix/presale/templates/pretixpresale/event/timemachine.html
index f613c6acd..80854bc1c 100644
--- a/src/pretix/presale/templates/pretixpresale/event/timemachine.html
+++ b/src/pretix/presale/templates/pretixpresale/event/timemachine.html
@@ -17,7 +17,7 @@
         <div class="panel-body">
             <form action="" method="post" class="">
                 {% csrf_token %}
-                {% bootstrap_form_errors timemachine_form %}
+                {% bootstrap_form_errors timemachine_form "all" %}
 
                 <p>{% trans "Test your shop as if it were a different date and time." %}</p>
 
@@ -30,14 +30,17 @@
                             {% if request.session.timemachine_now_dt %}{% trans "Change" %}{% else %}{% trans "Enable time machine" %}{% endif %}
                         </button>
                         {% if request.session.timemachine_now_dt %}
-                        <button name="timemachine_disable" value="true" type="submit" class="btn btn-default btn-lg btn-save">
+                        <button form="disable_form" type="submit" class="btn btn-default btn-lg btn-save">
                             {% trans "Disable" %}
                         </button>
                         {% endif %}
                     </div>
                 </div>
             </form>
-
+            <form action="" method="post" class="" id="disable_form">
+                {% csrf_token %}
+                <input type="hidden" name="timemachine_disable" value="true">
+            </form>
             <div class="clear"></div>
         </div>
     </div>
diff --git a/src/pretix/presale/views/event.py b/src/pretix/presale/views/event.py
index adedaeb9c..578f34835 100644
--- a/src/pretix/presale/views/event.py
+++ b/src/pretix/presale/views/event.py
@@ -931,7 +931,7 @@ class TimemachineForm(forms.Form):
     now_dt = forms.SplitDateTimeField(
         label=_('Fake date time'),
         widget=SplitDateTimePickerWidget(),
-        initial=lambda: now().astimezone(get_current_timezone())
+        initial=lambda: now().astimezone(get_current_timezone()),
     )
 
 
@@ -965,6 +965,8 @@ class EventTimeMachine(EventViewMixin, TemplateView):
         elif self.timemachine_form.is_valid():
             request.session['timemachine_now_dt'] = str(self.timemachine_form.cleaned_data['now_dt'])
             return redirect(eventreverse(request.event, "presale:event.index"))
+        else:
+            return self.get(request)
 
     def get_success_url(self) -> str:
         return eventreverse(self.request.event, 'presale:event.timemachine')