From 3443296a282cf1f3883e47c7e9a399fb44084e18 Mon Sep 17 00:00:00 2001
From: Raphael Michel <michel@rami.io>
Date: Thu, 12 Jan 2023 13:35:43 +0100
Subject: [PATCH] Device list: Hide revoked devices by default (#2996)

---
 src/pretix/control/forms/filter.py    |  2 +-
 src/pretix/control/views/organizer.py | 13 ++++++++++---
 2 files changed, 11 insertions(+), 4 deletions(-)

diff --git a/src/pretix/control/forms/filter.py b/src/pretix/control/forms/filter.py
index 78c3a93b7..3dda45050 100644
--- a/src/pretix/control/forms/filter.py
+++ b/src/pretix/control/forms/filter.py
@@ -2264,7 +2264,7 @@ class DeviceFilterForm(FilterForm):
     state = forms.ChoiceField(
         label=_('Device status'),
         choices=[
-            ('', _('All devices')),
+            ('all', _('All devices')),
             ('active', _('Active devices')),
             ('revoked', _('Revoked devices'))
         ],
diff --git a/src/pretix/control/views/organizer.py b/src/pretix/control/views/organizer.py
index 04cae1462..e202338b5 100644
--- a/src/pretix/control/views/organizer.py
+++ b/src/pretix/control/views/organizer.py
@@ -859,12 +859,19 @@ class DeviceQueryMixin:
     @cached_property
     def request_data(self):
         if self.request.method == "POST":
-            return self.request.POST
-        return self.request.GET
+            d = self.request.POST
+        else:
+            d = self.request.GET
+        d = d.copy()
+        d.setdefault('state', 'active')
+        return d
 
     @cached_property
     def filter_form(self):
-        return DeviceFilterForm(data=self.request_data, request=self.request)
+        return DeviceFilterForm(
+            data=self.request_data,
+            request=self.request,
+        )
 
     def get_queryset(self):
         qs = self.request.organizer.devices.prefetch_related(