CGM_Public/pretix_cgo
1
0
Fork 0
forked from CGM_Public/pretix_original
Code Pull Requests Actions Activity

Apply suggestions from code review

Browse Source 
Co-authored-by: Raphael Michel <mail@raphaelmichel.de>
This commit is contained in:
Lukas Bockstaller
2026-05-12 10:40:46 +02:00
committed by GitHub
parent 64e301ef47
commit 27966969f1
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/pretix/base/reldate.py
View File

@@ -46,7 +46,7 @@ EVENT_CHOICES = (
ORDER_CHOICES = ( ORDER_CHOICES = (
('datetime', _('Order creation')), ('datetime', _('Order creation')),
) )
ORDER_CHOICES_KEYS = [choice[0] for choice in ORDER_CHOICES] ORDER_CHOICES_KEYS = {choice[0] for choice in ORDER_CHOICES}
RelativeDate = namedtuple('RelativeDate', ['days', 'minutes', 'time', 'is_after', 'base_date_name'], defaults=(0, None, None, False, 'date_from')) RelativeDate = namedtuple('RelativeDate', ['days', 'minutes', 'time', 'is_after', 'base_date_name'], defaults=(0, None, None, False, 'date_from'))
@@ -87,7 +87,7 @@ class RelativeDateWrapper:
event = reference event = reference
base_date = getattr(reference, self.data.base_date_name) or event.date_from base_date = getattr(reference, self.data.base_date_name) or event.date_from
else: else:
raise ValueError("Only event, subevent or order objects are supported") raise TypeError("Only event, subevent or order objects are supported")
tz = ZoneInfo(event.settings.timezone) tz = ZoneInfo(event.settings.timezone)
@@ -186,7 +186,7 @@ class RelativeDateWrapper:
minutes=None, minutes=None,
is_after=len(parts) > 4 and parts[4] == "after", is_after=len(parts) > 4 and parts[4] == "after",
) )
if data.base_date_name in [k[0] for k in ORDER_CHOICES] and parts[4] != "after": if data.base_date_name in ORDER_CHOICES_KEYS and parts[4] != "after":
raise ValueError('ORDER_CHOICE: {} cannot be combined with "before"'.format(data.base_date_name)) raise ValueError('ORDER_CHOICE: {} cannot be combined with "before"'.format(data.base_date_name))
if data.base_date_name not in [k[0] for k in EVENT_CHOICES + ORDER_CHOICES]: if data.base_date_name not in [k[0] for k in EVENT_CHOICES + ORDER_CHOICES]:
raise ValueError('{} is not a valid base date'.format(data.base_date_name)) raise ValueError('{} is not a valid base date'.format(data.base_date_name))