Fix #571 -- Partial payments and refunds

src/pretix/plugins/banktransfer/views.py

@@ -14,9 +14,8 @@ from django.utils.timezone import now
 from django.utils.translation import ugettext as _
 from django.views.generic import DetailView, ListView, View
 
-from pretix.base.models import Order, Quota
+from pretix.base.models import Order, OrderPayment, Quota
 from pretix.base.services.mail import SendMailException
-from pretix.base.services.orders import mark_order_paid
 from pretix.base.settings import SettingsSandbox
 from pretix.base.templatetags.money import money_filter
 from pretix.control.permissions import (
@@ -66,15 +65,22 @@ class ActionView(View):
                 'message': _('The order has already been canceled.')
             })
 
+        p = trans.order.payments.get_or_create(
+            amount=trans.amount,
+            provider='banktransfer',
+            state__in=(OrderPayment.PAYMENT_STATE_CREATED, OrderPayment.PAYMENT_STATE_PENDING),
+            defaults={
+                'state': OrderPayment.PAYMENT_STATE_CREATED,
+            }
+        )[0]
+        p.info_data = {
+            'reference': trans.reference,
+            'date': trans.date,
+            'payer': trans.payer,
+            'trans_id': trans.pk
+        }
         try:
-            mark_order_paid(trans.order, provider='banktransfer', info=json.dumps({
-                'reference': trans.reference,
-                'date': trans.date,
-                'payer': trans.payer,
-                'trans_id': trans.pk
-            }), count_waitinglist=False)
-            trans.state = BankTransaction.STATE_VALID
-            trans.save()
+            p.confirm(user=self.request.user)
         except Quota.QuotaExceededException as e:
             return JsonResponse({
                 'status': 'error',
@@ -88,8 +94,12 @@ class ActionView(View):
         else:
             trans.state = BankTransaction.STATE_VALID
             trans.save()
+            trans.order.payments.filter(
+                provider='banktransfer',
+                state__in=(OrderPayment.PAYMENT_STATE_CREATED, OrderPayment.PAYMENT_STATE_PENDING),
+            ).update(state=OrderPayment.PAYMENT_STATE_CANCELED)
             return JsonResponse({
-                'status': 'ok'
+                'status': 'ok',
             })
 
     def _assign(self, trans, code):