From 14fcacfb4dac134b0fa62961f75d22e10fd5d90c Mon Sep 17 00:00:00 2001 From: Julian Rother Date: Tue, 16 May 2023 01:00:27 +0200 Subject: [PATCH] Fix Order._can_be_paid checks --- src/pretix/presale/views/order.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/pretix/presale/views/order.py b/src/pretix/presale/views/order.py index ebbc0412b..c1be32c3d 100644 --- a/src/pretix/presale/views/order.py +++ b/src/pretix/presale/views/order.py @@ -456,7 +456,7 @@ class OrderPaymentConfirm(EventViewMixin, OrderDetailMixin, TemplateView): self.request = request if not self.order: raise Http404(_('Unknown order code or not authorized to access this order.')) - if self.payment.state != OrderPayment.PAYMENT_STATE_CREATED or not self.order._can_be_paid(): + if self.payment.state != OrderPayment.PAYMENT_STATE_CREATED or self.order._can_be_paid() is not True: messages.error(request, _('The payment for this order cannot be continued.')) return redirect(self.get_order_url()) if (not self.payment.payment_provider.payment_is_valid_session(request) or @@ -526,7 +526,7 @@ class OrderPaymentComplete(EventViewMixin, OrderDetailMixin, View): self.request = request if not self.order: raise Http404(_('Unknown order code or not authorized to access this order.')) - if self.payment.state != OrderPayment.PAYMENT_STATE_CREATED or not self.order._can_be_paid(): + if self.payment.state != OrderPayment.PAYMENT_STATE_CREATED or self.order._can_be_paid() is not True: messages.error(request, _('The payment for this order cannot be continued.')) return redirect(self.get_order_url()) if (not self.payment.payment_provider.payment_is_valid_session(request) or @@ -571,7 +571,7 @@ class OrderPayChangeMethod(EventViewMixin, OrderDetailMixin, TemplateView): self.request = request if not self.order: raise Http404(_('Unknown order code or not authorized to access this order.')) - if self.order.status not in (Order.STATUS_PENDING, Order.STATUS_EXPIRED) or not self.order._can_be_paid(): + if self.order.status not in (Order.STATUS_PENDING, Order.STATUS_EXPIRED) or self.order._can_be_paid() is not True: messages.error(request, _('The payment method for this order cannot be changed.')) return redirect(self.get_order_url())