CGM_Public/pretix_cgo
1
0
Fork 0
forked from CGM_Public/pretix_original
Code Pull Requests Actions Activity

Silence ResponseError from redis (#2674)

Browse Source
This commit is contained in:
Raphael Michel
2022-06-06 12:27:33 +02:00
committed by GitHub
parent 97e74e4afb
commit 0dfef2699f
1 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/pretix/base/views/tasks.py
View File

@@ -36,6 +36,7 @@ from django.utils import timezone, translation
from django.utils.timezone import get_current_timezone from django.utils.timezone import get_current_timezone
from django.utils.translation import get_language, gettext as _ from django.utils.translation import get_language, gettext as _
from django.views.generic import FormView from django.views.generic import FormView
from redis import ResponseError
from pretix.base.models import User from pretix.base.models import User
from pretix.base.services.tasks import ProfiledEventTask from pretix.base.services.tasks import ProfiledEventTask
@@ -68,6 +69,11 @@ class AsyncMixin:
res.get(timeout=timeout, propagate=False) res.get(timeout=timeout, propagate=False)
except celery.exceptions.TimeoutError: except celery.exceptions.TimeoutError:
pass pass
except ResponseError:
# There is a long-standing concurrency issue in either celery or redis-py that hasn't been fixed
# yet. Instead of crashing, we can ignore it and the client will retry their request and hopefully
# it is fixed next time.
logger.warning('Ignored ResponseError in AsyncResult.get()')
except ConnectionError: except ConnectionError:
# Redis probably just restarted, let's just report not ready and retry next time # Redis probably just restarted, let's just report not ready and retry next time
data = self._ajax_response_data() data = self._ajax_response_data()